fgrsnau / ncm2-otherbuf

ncm2 plugin for completing words in other buffers
18 stars 3 forks source link

README.md outdated #6

Closed caneta closed 4 years ago

caneta commented 5 years ago

The installation instructions inside README.md file refers to a previous version of the plugin. They are

call plug#begin('~/.local/share/nvim/plugged')
Plug 'roxma/nvim-completion-manager'
Plug 'fgrsnau/ncm-otherbuf'
call plug#end()

but should be

call plug#begin('~/.config/nvim/plugins')
Plug 'ncm2/ncm2'
Plug 'fgrsnau/ncm2-otherbuf', { 'branch': 'ncm2' }
call plug#end()
fgrsnau commented 5 years ago

I honestly would rather like to make the ncm2 brach default and/or rename it to master. This would break all the existing setups though.

caneta commented 5 years ago

Renaming the ncm2 branch into master should be the best. I understand that this is a breaking change but updating the README with a Warning describing it, should be enough IMHO.

lougxing commented 5 years ago

This is my config, have no effect .

have effect: at first, open a.cc, then, :vsplit b.cc. If I edit a.cc, It completed with the keyword of b.cc.

$nvim a.cc
...
: vsplit b.cc 

no effect: open a.cc b.cc at once. If I edit a.cc,It didn't complete with the keyword of b.cc.

nvim a.cc b.cc

version:

NVIM v0.4.0-218-gf89d0d8
Build type: Debug
LuaJIT 2.0.5

$ git status
# On branch fix_4
nothing to commit, working directory clean

myconfig:

call plug#begin()

Plug 'ncm2/ncm2'
Plug 'roxma/nvim-yarp'
Plug 'ncm2/ncm2-path'
Plug 'fgrsnau/ncm2-otherbuf'

call plug#end()

let g:python3_host_prog="/usr/bin/python3"

"completion
autocmd BufEnter * call ncm2#enable_for_buffer()
set completeopt=noinsert,menuone,noselect
FatBoyXPC commented 5 years ago

Instead of renaming ncm2 to master, how about creating master from ncm2 and never update the ncm2 branch? You could include a bit in the README about this if people are wondering why they aren't getting updates.

I came here to see if this was mentioned because I'm annoyed of :PlugUpdate giving me this error and figured other people might not know how to specify the branch with vim-plug.

x ncm2-otherbuf:
    fatal: invalid reference: master
fgrsnau commented 4 years ago

The correct branch is now master. Using the branch ncm2 should display a message during startup.