fgsfdsfgs / perfect_dark

work in progress port of n64decomp/perfect_dark to modern platforms
MIT License
1.13k stars 70 forks source link

[Feature Request] Support for Japanese version #145

Open jonaeru opened 10 months ago

jonaeru commented 10 months ago

I have it, but most Japanese don't have Perfect Dark ROM of ntsc-final. If possible, I would be glad if I could play with Perfect Dark ROM of jpn-final.

fgsfdsfgs commented 10 months ago

It's not too difficult to allow building the port for other ROM versions and even provide autobuilds for them, since the decomp already supports this, but that would mean you'll have several different pd.exe files for each ROM, which will make it more difficult to test. Ideally I'd like to support loading ntsc-final, jpn-final and pal-final all in the same executable, but that will require quite a bit of work. I suppose we could go the "several executables" route for now. I'll see what I can do.

jonaeru commented 10 months ago

Thank you for considering my request.

jonaeru commented 10 months ago

https://github.com/fgsfdsfgs/perfect_dark/commit/d6854c412c4a36c74d51af21cb7b1dde0f2d2b1b

It's amazing! It is true that the Japanese is broken and needs to be corrected.

image image

iamgreaser commented 9 months ago

So, a little bit of insight as to what's going on, using the exit screen as a reference: image

戻る (modoru) may be correct, but the options should be はい (hai) and いいえ (iie). Instead they're getting the wrong glyphs, so in this instance it says ラオ and オオプ (these are gibberish). I think it's caching font glyphs incorrectly.

By the way, if you open and close other menus, the glyphs can change. image

("Yes, I would like a comb.")

fgsfdsfgs commented 9 months ago

This might be fixed with the latest commit. There are still no automatic builds for the jpn-final version though.

iamgreaser commented 9 months ago

Considering that it's now the Carrington Institute and not the Filenton Insitute or the Farnselectnplace, and you have an Options menu and not an Opetions menu, and the game doesn't ask if Lumi would like a comb, I think this is fixed.

@jonaeru Can you confirm this is fixed? 直しましたか?

jonaeru commented 9 months ago

Thanks! I have done nothing. I will check later.

jonaeru commented 9 months ago

I have not been able to see all of it, but from a rough check, it seems to be a no problem. Thank you so much.

Emulator: image ステージ背景(N64Emu版)

PC Port: image ステージ背景(PC版)

fgsfdsfgs commented 9 months ago

Alright, thanks for testing. I'll need to bring up automatic builds for it as well.

jonaeru commented 9 months ago

I think the half-width alphanumeric characters are the same font, but the Japanese version looks a little thicker.

PC Port ntsc-final (fff2fca): image

PC Port jpn-final (fff2fca) image

Emulator: image

iamgreaser commented 9 months ago

Seeing as you're using an HLE emulator, which emulator + plugins are you using?

When doing graphical comparisons, I encourage you to use an LLE emulator (anything which isn't plugin-based, usually - Ares is a pretty good one), or use LLE plugins with software rendering (for RSP and RDP) - paraLLEl-rsp should be fine for RSP, paraLLEl-rdp or angrylion should be fine for RDP.

This screenshot is from Ares, which should confirm that the HLE plugins are doing the right thing in this case:

image


It's not just the numbers - the copyright screen has the same font and is being rendered incorrectly:

pd-jpn-final port: image

Ares emulator: image

fgsfdsfgs commented 9 months ago

Huh, I thought it was supposed to be like this. Not sure why this happens.

jonaeru commented 9 months ago

Sorry, I used Project64 + GLideN64(HLE). I will try to compare with paraLLEl or N64 console in the future. I took new screenshots with N64 console.

N64 console: image image