search

fgsfdsfgs / sm64-port

PS2, PS3, OG Xbox and DOS ports of sm64-port.
https://discord.gg/7bcNTPK
242 stars 38 forks source link

[Software] "texture_filtering true" does not work #68

Open DrUm78 opened 2 years ago

DrUm78 commented 2 years ago

Hardware: FunKey S handheld device Software: https://github.com/DrUm78/sm64-funkey

texture_filtering true in "sm64config.txt" does not work in software mode on the FunKey S port, textures are still unfiltered. @fgsfdsfgs Does it work for you? Just would like to make sure it's not due to all the changes we made on the FunKey S port.

Thanks!

fgsfdsfgs commented 2 years ago

It's not implemented in software mode.

DrUm78 commented 2 years ago

Ah ok, I thought it was implemented as the readme says:

Set texture_filteringto false in SM64CONF.TXT to disable linear filtering (saves a lot of cycles in software mode)

Feel free to keep that ticket open if you planned to implement it, otherwise you can close it. 👍

fgsfdsfgs commented 2 years ago

That's actually for software OpenGL mode, when you run it under DOS with OSMesa.

DrUm78 commented 2 years ago

Ok no problem, tell me whether it's in the pipe or not, I will update the ticket status accordingly. 👍

fgsfdsfgs commented 2 years ago

There's a half-done Unreal-like dither filter in the code, but I didn't integrate it properly because it complicates the renderer a little bit and requires some workarounds to keep text still readable. Looks like this. That's about the best filtering you can get without slowing everything down significantly. image I might properly add it later, but probably not any time soon.

DrUm78 commented 2 years ago

Awesome, thanks for the info. 👍