search

fhackenberger / ktikz

KtikZ provides a nice user interface for making pictures using TikZ.
Other
350 stars 34 forks source link

KDE Frameworks port #12

Closed jfmcarreira closed 7 years ago

jfmcarreira commented 7 years ago

Are you interested in this pull request?

fhackenberger commented 7 years ago

Hi @jfmcarreira !

Would you be willing to keep maintaining the Qt5/K5 version here on this repository? I could add you as a collaborator!

Best, Florian

jfmcarreira commented 7 years ago

Dear Florian,

Yes I would be willing to maintain it, but I could use your help to finish the KDE Frameworks porting as I still requires the transition module (KDELibs4Support framework).

jfmcarreira commented 7 years ago

We could firstly merge my repo with yours in a different branch (i.e., frameworks branch) and them merge it when stable.

As at this moment there are somethings that are not working in the my frameworks port, e.g., recent files

fhackenberger commented 7 years ago

Hi Joao,

Sounds great! Unfortunately I can't help you out with that, as I literally have no time for this project and I'm not familiar with KDE Frameworks anymore either...

Maybe someone on the KDE IRC dev channels can help you out?

Best, Florian

On 17/08/17 17:42, Joao Carreira wrote:

Dear Florian,

Yes I would be willing to maintain it, but I could use your help to finish the KDE Frameworks porting as I still requires the transition module (KDELibs4Support framework).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fhackenberger/ktikz/pull/12#issuecomment-323112016, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3mWIHo4Ob38sBLMyskRiOmCx8ooakJks5sZF99gaJpZM4NW3C0.

-- DI Florian Hackenberger florian@hackenberger.at www.hackenberger.at

jfmcarreira commented 7 years ago

Dear Florian,

Ok we can merge as it is and keep it in a different branch. And merge it after when it gets stable and keep frameworks version the default one.

Regards,

João Carreira

fhackenberger commented 7 years ago

Ok, sounds like a good strategy. Can you please create a new PR for a separate frameworks branch? This one is for master, so I can't merge it straight away.

jfmcarreira commented 7 years ago

Did you finished you mod on the master branch? If so I will merge the master branch in my branch before the pull request.

fhackenberger commented 7 years ago

Jep, fell free to merge master into yours

On 17/08/17 18:18, Joao Carreira wrote:

Did you finished you mod on the master branch? If so I will merge the master branch in my branch before the pull request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fhackenberger/ktikz/pull/12#issuecomment-323122280, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3mWLo93Y-i-fqSNrMa5xijDmNBtGJzks5sZGfZgaJpZM4NW3C0.

-- DI Florian Hackenberger florian@hackenberger.at www.hackenberger.at