search

fhackenberger / ktikz

KtikZ provides a nice user interface for making pictures using TikZ.
Other
350 stars 34 forks source link

Switch fromAscii to fromLatin1 for Qt5 deprecation #9

Closed llimeht closed 7 years ago

llimeht commented 7 years ago

In pull request https://github.com/fhackenberger/ktikz/pull/6, QString's fromAscii was used. The QString method fromAscii is deprecated in favour of fromLatin1. The deprecated methods aren't even included in Qt5 builds unless specifically requested.

http://doc.qt.io/qt-5/qstring-obsolete.html#fromAscii

This change should be encoding safe but confirmation from @gprud would be good.

gprud commented 7 years ago

Thank you your patch. I’m still using Qt4; so I wasn’t aware of the deprecation of fromAscii. I think there is no problem to merge it.

fhackenberger commented 7 years ago

Merged

fhackenberger commented 7 years ago

Hey @gprud, I added you as a collaborator on the project, would you be willing to maintain it a bit here on GitHub?