fhamborg / news-please

news-please - an integrated web crawler and information extractor for news that just works
Apache License 2.0
1.99k stars 414 forks source link

Replace cchardet with the Python 3.11.x compatible faust-cchardet #245

Closed eliias closed 10 months ago

eliias commented 1 year ago

Hey,

thanks for all your work on news-please. We recently looked into bumping our production setup to Python 3.11 and realized that there is a transitive dependency that holds us back. I wonder if you would be willing to merge this PR to support Python 3.11 and onwards.

AFAIK, cchardet is not actively maintained, and lacks support for Python 3.11.x. There is a drop-in replacement in the form of the faust-cchardet package that other package maintainers seem to adopt (https://github.com/mailgun/talon/pull/233). The forked news-please repo passes our CI with these changes, but let me know if there are any other concerns from your side.

Thank You, Hannes