search

fhanau / Efficient-Compression-Tool

Fast and effective C++ file optimizer
Apache License 2.0
554 stars 40 forks source link

Please add unicode support #139

Open UpscaleAnon opened 2 months ago

UpscaleAnon commented 2 months ago

Come on already, it's been a major issue since 2016... You expect people to rename every file they have that for example has japanese characters?

xBZZZZ commented 2 months ago 
ect -zip 🥜

created valid 🥜.zip for me (linux x86-64)

UpscaleAnon commented 2 months ago 
ect -zip 🥜

created valid 🥜.zip for me (linux x86-64)

Doesn't work on Windows 10.

G:\ECT>ect -5 "G:\ECT\80750022_p0 - イラストリアス.jpg" No compatible files found

G:\ECT>ect -5 "G:\ECT\🥜.jpg" No compatible files found

fhanau commented 2 months ago

Hi, ECT is not under active development so I will not be adding new features like Unicode support for the foreseeable future unfortunately. As a German speaker, this also affects me with [äöüẞ] characters not being usable (this is of course a larger issue with other languages). Adding support for Unicode characters would not be trivial as ECT includes several libraries that perform file I/O. identifying all such cases and implementing a unified approach for I/O that supports all file formats, then fixing any bugs in edge cases would be a larger effort. I think xBZZZZ is saying that zip file creation appears to work with him. If that's the case that is great although I can't guarantee that this applies in all cases, especially since zip file creation for one file and for several files uses different code paths IIRC.