jollyrogers88 commented 7 years ago

I've tried to compile with ArchLinux. Just used make / make install. Dependencies and nasm are present, compiler: gcc 6.2.1

With libjpeg-turbo, but without mozjpeg, it just fails make[3]: Verzeichnis „../Efficient-Compression-Tool-0.6.1/src/mozjpeg“ wird verlassen

With mozjpeg, the following compilation error happens:

g++ -Ofast -std=gnu++11 main.cpp blocksplitter.o codec.o image.o lz77.o opngreduc.o squeeze.o util.o LzFind.o support.cpp zopflipng.cpp zopfli/deflate.cpp zopfli/zopfli_gzip.cpp zopfli/katajainen.cpp lodepng/lodepng.cpp lodepng/lodepng_util.cpp optipng/optipng.cpp jpegtran.cpp gztools.cpp mozjpeg/.libs/libjpeg.a libpng/libpng.a zlib/libz.a -o ../ECT
/tmp/ccu3X25P.o: In function `DeflateSplittingFirst2(ZopfliOptions const*, int, unsigned char const*, unsigned long, unsigned long, unsigned char*, unsigned char**, unsigned long*, unsigned int, unsigned char, ZopfliLZ77Store*)':
deflate.cpp:(.text+0x502e): undefined reference to `pthread_create'

fhanau commented 7 years ago

Hm, there appears to be a problem with multithreading, it worked for me using Ubuntu. It will work with mozjpeg if you disable multithreading using make CXXFLAGS='-DNOMULTI -Ofast -std=gnu++11' The -pthread flag could also be causing problems, so try make CXXFLAGS='-Ofast -std=gnu++11'

There currently is no make install.

tssajo commented 7 years ago

I ran into the exact same problem on Debian Jessie when I was trying to compile ECT release 0.6.1

This worked for me: make CXXFLAGS='-DNOMULTI -Ofast -std=gnu++11'

metalshark commented 7 years ago

I had joy on Debian Jessie 8.8 by just going into the src/mozjpeg folder and running ./configure --host=i686-linux-gnu followed by make then continuing the main build in the src folder. Without custom CXXFLAGS, etc

peletiah commented 7 years ago

In Ubuntu 14.04.5 I ran into this error:

make[1]: Entering directory `/tmp/Efficient-Compression-Tool/src/mozjpeg'
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /tmp/Efficient-Compression-Tool/src/mozjpeg/missing aclocal-1.15 
/tmp/Efficient-Compression-Tool/src/mozjpeg/missing: line 81: aclocal-1.15: command not found
WARNING: 'aclocal-1.15' is missing on your system.
         You should only need it if you modified 'acinclude.m4' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'aclocal' program is part of the GNU Automake package:
         <http://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/autoconf>
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make[1]: *** [aclocal.m4] Error 127
make[1]: Leaving directory `/tmp/Efficient-Compression-Tool/src/mozjpeg'
make: *** [mozjpeg] Error 2

Additional flags like above didn't work, but I managed to build it like this:

$ sudo apt-get install nasm
$ git clone --recursive https://github.com/fhanau/Efficient-Compression-Tool.git
$ cd Efficient-Compression-Tool/src/mozjpeg
$ touch aclocal.mp4 configure
$ touch Makefile.am
$ touch Makefile.in
$ cd ..
$ make
$ cd..
$ ./ect

fhanau commented 7 years ago

I could not reproduce this problem with Ubuntu 17.04. However, I ran aclocal and autoreconf on mozjpeg, which should fix these problems. Please reopen this if your problem persists.