fhb1990 / CityJSON-viewer

Online viewer for CityJSON files.
1 stars 8 forks source link

opening a new file keeps the old one #16

Open hugoledoux opened 5 years ago

hugoledoux commented 5 years ago

but since you modify coordinates then it gets messy, see below.

Probably simpler to just flush the old model and always keep one and one, no? 2019-08-21 at 14 14

fdahle commented 5 years ago

Originally this function is intentionally designed like this. The case could be that the user have splitted files, for example a houses.json and a streets.json.

Should I therefore keep this feature or put it out?

hugoledoux commented 5 years ago

OK yeah it's nice, let's keep it.

But there seems to be something a bit wrong. I splitted Den Haag from https://www.cityjson.org/datasets/ into terrain.json and buidlings.json, and when I open them both the terrain is "higher", see: 2019-09-19 at 16 11

If I open them in azul, all is good.

Possible that it works if both have the same bbox since you rescale? If the case then in practice it's nearly impossible to have, and then I'd drop the feature. If fixable then I'd keep it.

hugoledoux commented 5 years ago

also, if you pick say 3 buildings from a dataset and put them in a different dataset then open both, you can this (scaling issues):

2019-09-19 at 16 23

fdahle commented 5 years ago

I'm currently investigating to not normalize the coordinates, as so the relation of the objects (also from different files) should be kept. The current status is that it works - but I still have some problems with the camera and the light, as the whole scene is shifted vertically image