search

fhcrc / deenurp

16S rRNA gene sequence curation and phylogenetic reference set creation
GNU General Public License v3.0
4 stars 3 forks source link

pep 440 versioning bug #31

Open crosenth opened 9 years ago

crosenth commented 9 years ago

setuptools really does not like non-pep 440 versions and will complain when installing and running unittests to the point where the package is completely corrupted after running unittests. Solutions is to have pep 440 versioning to make it happy.

crosenth commented 9 years ago

Versions are now major.minor.micro with -dev[commit#] if developing above the git tag commit.

crosenth commented 9 years ago

I'm not sure how I've solved this will work from pypi or when installing from Github.

crosenth commented 9 years ago

Okay, wrapped the git describe --tags with a try except block so hopefully that takes care of it.

crosenth commented 9 years ago

I'm reopening this because I don't think it will work in all cases first try.

crosenth commented 8 years ago

seems to work for now but will leave this open for a while in case something comes up

crosenth commented 8 years ago

btw, it's here https://github.com/fhcrc/deenurp/blob/generalize_from_rdp/version.py

crosenth commented 8 years ago

Need some unittests.