search

fhcrc / seqmagick

An imagemagick-like frontend to Biopython SeqIO
http://seqmagick.readthedocs.org
GNU General Public License v3.0
113 stars 22 forks source link

Python 3 compatibility #67

Closed nhoffman closed 6 years ago

nhoffman commented 6 years ago

I think this is ready to release. I don't think that I have access to the pypi or readthedocs accounts, though.

nhoffman commented 6 years ago

@matsen - please just let me know if you're ok with the concept of a python3-only release - no need to go through all of the changes! I'll probably need help with credentials for uploading to pypi and readthedocs, unless @crosenth has them.

matsen commented 6 years ago

Noah, this seems great but before I merge could @crosenth cut another release with the very latest 2.7 code? v0.6.2 or so? Then we can have something fixed to point the old-schoolers to.

cmccoy commented 6 years ago

Noah (hey!), I think you should have PyPI access:

Package Index Owner: cmccoy, Noah.Hoffman, bcclaywell

On Fri, Jan 5, 2018 at 8:12 AM, Erick Matsen notifications@github.com wrote:

Noah, this seems great but before I merge could @crosenth https://github.com/crosenth cut another release with the very latest 2.7 code? v0.6.2 or so? Then we can have something fixed to point the old-schoolers to.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fhcrc/seqmagick/pull/67#issuecomment-355594066, or mute the thread https://github.com/notifications/unsubscribe-auth/AAielCOjmG0kJ_4M44YNq_OINs2_ZhAcks5tHkntgaJpZM4RUDnm .

nhoffman commented 6 years ago

@cmccoy - hey there and thanks! Not quite sure about the docs, though: it's easy enough to update the version on GH pages (https://fhcrc.github.io/seqmagick/), but not sure about https://pythonhosted.org/seqmagick or http://seqmagick.readthedocs.org - it's kind of confusing to have all three! @matsen - any thoughts about which we should maintain?

nhoffman commented 6 years ago

@matsen - there doesn't seem to be a tag for 0.6.2 (is this a release or was that a typo?), but a tarball for 0.6.1 is uploaded to pypi. I'll definitely add a note to the README about how to install for python2, and make sure that the old tarball is visible on pypi.

matsen commented 6 years ago

I was saying that we should cut a 0.6.2 release, put it on https://github.com/fhcrc/seqmagick/releases and pypi. Gee, seems like the RTD thing is the most up to date, so perhaps we should continue that?

nhoffman commented 6 years ago

Got it - I didn't think to see if there were unreleased changes in master. I'll tag whatever is in master as 0.6.2, publish to pypi, and then release 0.7.0. Thanks!

nhoffman commented 6 years ago

Ok, I released 0.6.2. Here's the updated readme, which notes how to install using python2.7: https://github.com/fhcrc/seqmagick/blob/python3-nh/README.rst

Pretty sure I'm ready to release 0.7.0 - I can publish tarball to pypi and updated docs to github pages, but I'm not sure how to update docs in other locations.

matsen commented 6 years ago

OK, merged. Make a release and I think RTD will update automagically