Closed avahoffman closed 1 year ago
No spelling errors! :tada: Comment updated at 2023-03-14 with changes from a3eb801349abea40e82dd8df7407f68b0d18f218
No broken urls! :tada: Comment updated at 2023-03-14 with changes from a3eb801349abea40e82dd8df7407f68b0d18f218
Re-rendered previews from the latest commit:
Updated at 2023-03-14 with changes from a3eb801349abea40e82dd8df7407f68b0d18f218
Looks great! I kinda wonder if this should go at the beginning of the writing the plan section (just seems like the most relevant spot)? I could be persuaded to keep it where it is though!
I also noticed that we use a different acronym for the plan between the app and the course - should we choose one to stay consistent? DMSP vs DSMP... I think we went with DMS initially because the NIH is calling it the Data Management and Sharing Policy. But I think DSMP is used sometimes by some tools or something
Thanks for fixing the repo link!
I also noticed we have some warning messages in the about this course section after the first paragraph
I was hoping to make sure folks saw it early, and were aware of its existence. I don't want it to get buried.
maybe we could have a shout out in the beginning and a reminder in the writing section?
I think this might be a tad confusing, but I thought DSM Plan Helper would be too long of a url / title.
would it not just be rearranging the letters from DSMP to DMSP? maybe I am missing how that would change the url/title?
Thanks for fixing the repo link!
NP!
Addressed in https://github.com/fhdsl/NIH_Data_Sharing/pull/96
oh ok, cool
Also looks like the link is to the course where the app page is- I imagine we want the link to the app?
oops sorry didn't mean to edit your comment! Idk whyI did that!! little scattered
These were my responses to you:
I was hoping to make sure folks saw it early, and were aware of its existence. I don't want it to get buried.
maybe we could have a shout out in the beginning and a reminder in the writing section? (Thinking it might be good to say something like for those who are already familiar, you could skip to this app, otherwise keep reading kinda thing and then at the later point say now that you know about the policy, consider using the app?)
I think this might be a tad confusing, but I thought DSM Plan Helper would be too long of a url / title.
would it not just be rearranging the letters from DSMP to DMSP? maybe I am missing how that would change the url/title?
Addressed in https://github.com/fhdsl/NIH_Data_Sharing/pull/96
oh ok, cool
@carriewright11 no worries. I have to change the library name and shiny deployment so that might take a bit.
And yes, I think a shoutout at the writing stage is a good idea. will add!
@carriewright11 that didn't take as long as I thought 😜 How are things looking now?
@carriewright11 that didn't take as long as I thought 😜 How are things looking now?
Looking very good! 😊 The name etc. on the app looks awesome! I wonder if we could make the app even more prominent in the writing section?- like maybe include a section heading and image about again? I say this because even though I knew where it was from the diff I went past it a couple of times in the preview. (I personally think the redundancy would be fine... could call it something else)
I agree that we don't want people to miss it!
Maybe also adding a statement when you introduce the app, saying for those familiar with the policy, you could skip directly to creating your plan with our app could help? Or are you afraid that will discourage people from reading the rest?
cow::borrow_chapter
once approved@carriewright11 I recycled the content like so. Thoughts?
Looks great!
_bookdown.yml