search

fhdsl / metricminer

R package that digs up data that matters from APIs, making it dashboard-ready
https://hutchdatascience.org/metricminer/
MIT License
2 stars 0 forks source link

Deal with GitHub API Error (404) #21

Closed howardbaik closed 10 months ago

howardbaik commented 10 months ago

I used purrr::possibly() to handle calls that throw an error message. For those calls, this sets the value to be "Not Found".

NOTE: Even with this change, I still get this warning:

Warning message:
In rep(no, length.out = len) : 'x' is NULL so the result will be NULL

I think this might have to do with ifelse(). Further investigation to be had.

cansavvy commented 10 months ago

@howardbaek thanks for this add! I'm definitely going to look into this. But probably not until Monday. Take a look at the Google analytics pr. I think that should have less bugs 🤞 and if so you can start building the dashboard around that while I address GitHub bugs.

cansavvy commented 10 months ago

Ah now I understand. I did fix some of these thing but the fixes are on #16