search

fhdsl / metricminer

R package that digs up data that matters from APIs, making it dashboard-ready
https://hutchdatascience.org/metricminer/
MIT License
2 stars 0 forks source link

Mask user input when providing token #67

Closed howardbaek closed 7 months ago

howardbaek commented 7 months ago

I noticed that readline() doesn't conceal the tokens that the user provides in the R console. For security reasons, I replaced readline() with getPass::getPass(), which hides user input. See here for more info on the getPass package.

Also, I made a few minor changes, like title-casing the name of apps and spelling out 'creds'.

cansavvy commented 7 months ago

This is an excellent add! Thanks for thinking about this and implementing it! It looks like everything is still running properly so we can merge this!

Excellent! @howardbaek