Updating google analytics metrics getter

fhdsl / metricminer

R package that digs up data that matters from APIs, making it dashboard-ready

https://hutchdatascience.org/metricminer/

MIT License

2 stars 0 forks source link

Updating google analytics metrics getter #73

Closed cansavvy closed 7 months ago

cansavvy commented 8 months ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Fixing up some things for usability and DRYness purposes.

The google analytics all_ga_metrics() is being deprecated changed so it can take property ids instead of just taking all properties from an account.

In order to do this, we needed to make a new function get_ga_property_info() that will allow a display name (and other info) for a property to be retrieved.

cansavvy commented 8 months ago

I also ran styler::style_dir("R") so a lot of the changes have to do with that.

I can separate out these changes if it makes it to hard to review, but I tried to highlight the actual changes.

cansavvy commented 7 months ago

We tested this in a pair programming session and found out it was because Howard was trying to access a property id with the hutchgmail account that it does not have access to. Tried to fix the docs appropriately.