fhemberger / dssim-bin

[MAINTAINERS WANTED] dssim-bin wrapper that makes it seamlessly available as a local dependency
MIT License
3 stars 2 forks source link

wip: build rust project & travis CI setup #5

Closed awerlang closed 6 years ago

awerlang commented 6 years ago

This is a work in progress. This needs some help to get it done.

Closes #4

fhemberger commented 6 years ago

Wow, thanks! This looks great already.

So I think the only thing I need to add is:

Right?

awerlang commented 6 years ago

The current issue is identifying the correct output

It may be related to a convention where programs should be placed inside src/bin but in the archive both main.rs and lib.rs are in the same directory.

After this, is it possible to deploy to npm binaries produced in separate jobs (linux & os x) straight from travis?

fhemberger commented 6 years ago

Ok, found one source of the problem. You were still pulling v1.3.3 of dssim, not the 2.x release. I map the dssim version number to the version of the npm package.

Updating to the current 2.9.4 release gives me a proper binary: vendor/release/dssim. See https://github.com/fhemberger/dssim-bin/pull/6 for my test PR.

awerlang commented 6 years ago

You're right! But still this is the output in travis:

$ ls vendor/release/build
rayon-core-29a42b65b777dc05  rayon-core-af02fc9cf039ecce
awerlang commented 6 years ago

Another option, as suggested to me on S.O., is to use the cargo install command directly.

cargo install dssim --version ${version}

Only I don't know how we could pass the version to travis.

fhemberger commented 6 years ago

Binary is in vendor/release, not vendor/release/build.

awerlang commented 6 years ago

Great

fhemberger commented 6 years ago

@awerlang Sorry it took so long, merged your PR. Thanks! I'm not sure yet how to proceed with the Rust build.