search

fhir-crucible / crucible

🔥 Crucible web application for testing FHIR servers
77 stars 25 forks source link

Test "X010: ImagingManifest: Create New" payload does't match FHIR 3.0.1 resource content #290

Open Rende11 opened 5 years ago

Rende11 commented 5 years ago

Resource Test Imaging Manifest

http://hl7.org/fhir/STU3/imagingmanifest.html#resource

"diagnostics": "{:path [:study 0 :series 0 :instance 0 :frameNumber], :message \"extra property\"}"

pcosmog commented 5 years ago

+1 - also running into this issue

arscan commented 5 years ago

Thanks for the report @Rende11, and sorry for the slow response here.

@jawalonoski -- it looks like we are including a phantom 'frameNumber' element in STU3 ImagingManifest (within ImagingManifest.study.series.instance).

See https://github.com/fhir-crucible/fhir_models/search?q=frameNumber&unscoped_q=frameNumber

My guess is that this was removed between v3.0.0 and v3.0.1, and we generated our files from v3.0.0. The generation time of the source imagingmanifest.xsd file in our repo says: Generated on Wed, Apr 26, 2017 18:33-0400 for FHIR v3.0.0, which has frameNumber.

If you compare it to the v3.0.1 imagingmanifest.xsd, you'll see a different version, generation date, and the frameNumber element is now gone.

At this point should we just fix the frameNumber element manually in the rb file, or regenerate with v3.0.1?

arscan commented 5 years ago

This is very weird. We did update to v3.0.1, but apparently we got a wrong set of files, because despite being v3.0.0 it has a later generation date than what is in the v3.0.1 files from HL7. And obviously there is a mismatch in the structure of this resource.

I think this is likely the cause of #289 as well.