search

fhir-crucible / crucible

🔥 Crucible web application for testing FHIR servers
77 stars 25 forks source link

Crucible passes an invalid sopClass #300

Closed pcosmog closed 5 years ago

pcosmog commented 5 years ago

When crucible attempts to create an imaging study, it passes us:

"sopClass": "urn:oid:2",

The "sopClass" element is of type oid (http://hl7.org/fhir/STU3/imagingstudy.html)

The regex for validating an oid in the spec is (http://hl7.org/fhir/STU3/datatypes.html#oid): urn:oid:[0-2](\.[1-9]\d*)+

You can use a regex tester (like https://regex101.com/) to see that "urn:oid:2" does not pass this regex, it's invalid. It needs to have at least one period followed by a number.

Our server rejects the create attempt due to the invalid OID, and Crucible is incorrectly failing the test as a result.

arscan commented 5 years ago

Deployed a fix, thanks. There was a ~8% chance that a given oid was invalid. Let me know if it looks ok on your end.

pcosmog commented 5 years ago

Confirmed fixed.