search

fholger / RocksmithToTab

Exports Rocksmith 2014 songs to Guitar Pro tabs
http://www.rocksmithtotab.de
BSD 2-Clause "Simplified" License
207 stars 36 forks source link

Add Version number in output name #11

Closed MadMaxxx closed 10 years ago

MadMaxxx commented 10 years ago

It was discussed in the thread a few times, the version number is stored in the psarc since quite a while now, just grab the latest revision of the toolkit. Maybe you can get it from inside the .psarc instead from the input file name.

Here some additional information about the version fied. Its only allowed to enter version number likes this 1.4 the point will get translated once the package is generated into an underscore. So in the toolkit you have to enter for example 1.4 and the output will be called artist-song_v1_4_p.psarc.

If you load an older toolkit template with a version number that does not match the requirement the toolkit will throw a message and you have to edit the version field. This was actually added in the latest revision of the toolkit from yesterday.

jnettels commented 10 years ago

For me it would be sufficient to include the version number in the comments property of the gp5 file as I proposed here: https://github.com/fholger/RocksmithToTab/issues/10

I like the current "clean" look of the filenames.

fholger commented 10 years ago

I'm toying with the idea of making the output filename configurable, i.e. specify a template via the command line. For example, something like "{artist} - {title}" would describe the current format, and I could add a few other fields.

jnettels commented 10 years ago

Sounds good. This could be implemented into the Custom Toolkit in a very user-friendly way, e.g. as a text box where you can define this string including a dropdown menu with common examples.