search

fholger / RocksmithToTab

Exports Rocksmith 2014 songs to Guitar Pro tabs
http://www.rocksmithtotab.de
BSD 2-Clause "Simplified" License
211 stars 36 forks source link

Depricated Version #18

Closed cozy1 closed 10 years ago

cozy1 commented 10 years ago

Please consider releasing branch with VS2010, NET40 compatible source and executable for those of us poor slobs still running WinXp. Thanks

fholger commented 10 years ago

The reason I'm targeting NET45 is because of the leaveOpen parameter to the StreamReaders, because I found the workaround solution for older versions plain ugly. However, I'm currently working on Mac compatibility, and there appears to be a principal problem with how the whole psarc archive handling is currently done within my code and in the toolkit. So I'm currently trying to figure out a workaround for this issue, and in the process it may easily happen that my need for that parameter goes away. Then I'll happily downgrade the target to NET40 :)

cozy1 commented 10 years ago

With help from Alex360, we have a clean native work around. It loads in VS2010 with NET40 nicely. I will be glad to contribute. I added a branch (Vs2010Net40Support) to my fork of your repository in case you want me to make a pull request. You can take a look at code there if you want

fholger commented 10 years ago

Normally, yes, but in this case I have already seen the solution. It's nice and clean, and I would normally adapt it. But as I said, I'm working on getting Mac support in, and I'm currently in the process of changing the whole PSARC handling. So the problematic code will go away, anyway :) I hope to finish the changes tonight or sometime tomorrow. Stay tuned.

fholger commented 10 years ago

I've put out a new release with the changes for Mac. I've also retargeted the project to .Net 4.0. Please let me know if that does the trick for you.