fholger / openvr_foveated

Fixed Foveated Rendering for SteamVR games
Other
120 stars 4 forks source link

[IL-2 Sturmovik]: Pimax canted displays double rings in left eye #7

Open BrziJoe opened 2 years ago

BrziJoe commented 2 years ago

Which game is affected? IL-2

Describe the issue Hi Fholger. Nice to see this tool, after your last one, Openvr_FSR. In that last tool you solved right positioning of the center of the screens for canted displays. Now in a new tool only the sharpening circle works good, and foveated circles are not good: 1) foveated circles are actually ellipse (similar to VR view ratio), but sharpening circle is still circle. Please make all or one or another, do not mix. Maybe booth as circles? 2) Right eye is correct booth in game mirror, and in game (there is only one center for all foveated radiuses, and for sharpening circle). Left eye has problems; there sharpening circle is correct (in the sweet spot), but all 3 foveated ellipse are shown 2 times; once in sweet spot (closer to inner edge), and one more time as duplicate of right eye positions (closer to the outer edge). Can you please check what is happening with that left eye, and make it same as sharpening circle?

PS: IL-2 is "special case". I saw similar mistakes in this game with Open_FSR branches from RamesTheGeneric and from Dazbme (see link: https://github.com/fholger/openvr_fsr/issues/27 ), but you solved everythig there with your calculation. Please, please, please use same calculation in this tool

Hardware Pimax 8kx (canted displays), 2080Ti

Config and log I made several tests, in sets 01, 02 and 03. The 03 has everything, but I added first two also. On end I added one more screenshot (name XX...) there is OpenVR_FSR working perfect! What to look? I tried to look with right eye to the wing tip. It should always be wing tip in center of all views. Problems are on left eye only. 02 il2 large fov 05 06 07 08

il2 partialy working.zip

fholger commented 2 years ago

It is already using the exact same calculations for the center, and in fact, as you can see, the center actually is identical on all rings. I have no idea right now why the foveated rings would appear as an ellipse, that's certainly not intended. It could, however, point to some underlying compatibility problem with the game. The left eye is definitely some kind of incompatibility.

You can try to disable post-processing effects in the game, specifically any form of temporal anti-aliasing and such. Perhaps you find a setting that helps (may require game restart).

BrziJoe commented 2 years ago

I already disabled all possible post processing (TAA, MSAA, AA, SS, camera smoothness...) It is strange how sharpening is using just different area shape, even if I set same radius for it and 1 foveated ring. I do not know how did you avoid that same mistake with sharpening, it was same error in AMD_FSR at beginning.

PS: In Skyrim everything works good (after disabling TAA). About 10% more fps with some strong settings, maybe too strong for my taste.

BrziJoe commented 2 years ago

PS2: just for the record, ellipse shape of foveated rings are on all games. Horizontal and vertical radius are correlating with screen aspect ratio.

BrziJoe commented 2 years ago

I tried new version of mod, with "Variable Rate Shading" (VRS on my 2080ti); VRS crashes IL-2 game in flight in less then minute. Unfortunately, same crash as with Pimax native foveated rendering.

I did try it in other games, and VRS works much much better then with first version ("Radial Density Masking"). The circles are less visible, almost non existent.

Benefits of VRS foveated, frame time: Skyrim: 9,5ms with VRS (13ms native) Follout4vr: 16,5ms with VRS (18,5-19ms native)

PS: for VRS foveated I had to disable Steam overlay (Steam/settings/in game/ Steam overlay disable). With overlay on, it crashes in 2 seconds. "Radial Density Masking" was not affected by steam overlay

BrziJoe commented 2 years ago

If somebody needs to see visual difference of 2 types of foveated rendering (VRS vs RDM), I extracted middle parts from screenshots in Skyrim: https://community.openmr.ai/t/fholger-fsr-openvr-foveated/37832/6?u=brzijoe

RavenSystem commented 10 months ago

Check it out: https://forum.il2sturmovik.com/topic/86271-mod-new-vr-performance-toolkit-rsf/