search

fhorinek / BB

GNU General Public License v2.0
29 stars 16 forks source link

[bug] Fix fanet issue for negative lat/long #506

Closed kolupaev closed 9 months ago

kolupaev commented 9 months ago

FANET protocol uses 2 compliment 24bit integers.

As C does not support it, adding a manual conversion.

Issue reproducible in north-america, and manifests as glider showing far left.

After the fix location is displayed correctly. Verified via soft-rf transmitter.

See https://github.com/fhorinek/BB/issues/497

bubeck commented 9 months ago

In general this looks good to me. However, I am unable to test, because I live in germany (positive lat/lon).

kolupaev commented 9 months ago

In general this looks good to me. However, I am unable to test, because I live in germany (positive lat/lon).

Tested it locally with Soft-rf, works as expected on negative. Would that be sufficient?

bubeck commented 9 months ago

Tested it locally with Soft-rf, works as expected on negative. Would that be sufficient?

Must be decided by @fhorinek

kolupaev commented 9 months ago

Ah, Thanks for CC-ing right people :) Was not sure who is a project owner here