search

fhqvst / avanza

A JavaScript client for the unofficial Avanza API
MIT License
228 stars 59 forks source link

Fix/following routes #103

Open linus-skold opened 7 months ago

linus-skold commented 7 months ago

This change fixes the paths that has been changed and resolves an issue where you'd receive 302 Temporarily Moved by following the redirect.

origooo commented 4 months ago

Any thoughts on merging this pull request? It seems the new paths are required.

Btw @linus-skold, haven't you missed those path parts {0} etc in SEARCH_PATH and TRANSACTIONS_PATH? And, are all the new/updated paths used in any API methods?

linus-skold commented 4 months ago

@origooo good catch with the path parts, completely overlooked them when copying the paths from https://github.com/fhqvst/avanza/issues/99#issuecomment-1510150144 Added them.

That's a really great question, if they are completely new, new constant, then they are not in use by anything but there's no harm in adding them to increase visibility of them if something needs to use it.

The updated ones are still in use as far as I know, and is still in use the same way as before. Any issue connected to them doing something else should probably be addressed, but in that case we should create new issues and link them here.