Added FILL OR KILL order type.

fhqvst / avanza

A JavaScript client for the unofficial Avanza API

MIT License

229 stars 59 forks source link

Added FILL OR KILL order type. #23

Closed ausrasul closed 5 years ago

ausrasul commented 5 years ago

Added FILL_OR_KILL order type using web api.
For details see API.md (added: placeWebOrder)
Added test case.

ausrasul commented 5 years ago

Implementation credit @gustafg

fhqvst commented 5 years ago

Hi! Have not had the time to look into this – sorry for that!

I believe using the proposed route will result in CORS errors, but on the other hand this is not a problem unless we're in a browser settings. Also, I'm guessing these routes probably have a higher risk of being changed in the future, compared to the mobile API ones.

Anyways, I'm happy to merge if you want to reopen again!

ausrasul commented 5 years ago

Hi, Although it works from nodejs, I do agree with you. I also find out that not all instruments works with FOK orders. Which proved ... problematic. That is why I closed this PR.