search

fhrf / fhrf.github.io

The official website of Human Rights NGO - First Human Rights Foundation
https://fhrf.in
3 stars 15 forks source link

Removed commented css #6

Closed shngt closed 4 years ago

shngt commented 4 years ago

Removed commented css and empty classes. Related to issue #3

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fhrf/fhrfin/f9jwqampv
✅ Preview: https://fhrfin-git-fork-shngt-css-cleanup.fhrf.vercel.app

shngt commented 4 years ago

@cTxplorer could you please review?

cTxplorer commented 4 years ago

@shngt thanks for raising the PR Just curious - did you cross-checked if there's any class style defined in CSS, but the class isn't ever used in html?

shngt commented 4 years ago

Ah no, I haven't. Will do

shngt commented 4 years ago

Umm so I don't see an element with the fas class in the footer - would that make "footer .fas" irrelevant? Rest seems relevant to me

cTxplorer commented 4 years ago

LGTM, thanks for the PR @shngt !

Please feel free to squash bugs that you think should be fixed or improvements that can be made.

shngt commented 4 years ago

Sure, thank you!