search

fhs / NPZ.jl

A Julia package that provides support for reading and writing Numpy .npy and .npz files
Other
117 stars 16 forks source link

Update to Julia 0.6-1.0, drop support for 0.4-0.5 #24

Closed galenlynch closed 5 years ago

galenlynch commented 5 years ago

Sorry about the changes to white space, I didn't realize that some parts of the code used tabs until it was too late.

galenlynch commented 5 years ago

Failures on 1.0 are from Zip.jl

fhs commented 5 years ago

Sorry about the tabs. I've changed them to spaces. Can you rebase? Thanks.

galenlynch commented 5 years ago

done

galenlynch commented 5 years ago

I fixed the unicode problems.

fhs commented 5 years ago

I can't say I'm happy with the new string indexing -- it's too verbose. But it's acceptable.

fhs commented 5 years ago

Thanks for all the fixes!

galenlynch commented 5 years ago

Seems like the price you have to pay if you want to play with unicode. Thanks again for maintaining such a useful package!