Closed jishnub closed 3 years ago
Merging #44 (37374e4) into master (9a66947) will increase coverage by
0.85%
. The diff coverage is92.10%
.
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 85.29% 86.15% +0.85%
==========================================
Files 1 1
Lines 170 195 +25
==========================================
+ Hits 145 168 +23
- Misses 25 27 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/NPZ.jl | 86.15% <92.10%> (+0.85%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9a66947...37374e4. Read the comment docs.
Thank you for your package! Could you tag a new version by commenting @JuliaRegistrator register
on the merged commit?
Error while trying to register: Register Failed @jishnub, it looks like you don't have collaborator status on this repository.
Thank you for your package! Could you tag a new version by commenting
@JuliaRegistrator register
on the merged commit?
Ok, commented
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.
This PR does two things:
Header
type parametric and concrete: this seems to cut down on allocations while reading arraysOn master:
After this PR:
The difference in run-time is marginal.
readheader
that returns the header. This might be convenient to get theeltype
andsize
of the array without reading it in (eg. to pre-allocate an array of the correct size). This function is not exported.