search

fhs / go-netcdf

Go binding for the netCDF C library.
MIT License
37 stars 12 forks source link

Add method to get the value attribute of type text #4

Closed ronanj closed 3 years ago

ronanj commented 8 years ago

Add a new method to get the value of an attribute of type text Updated documentation

ronanj commented 8 years ago

Are the new changes ok for merging?

ronanj commented 8 years ago

Changes have been done according to your comments.

Also, two methods have been added to nc_char.go, to simplify the usage of the 'BytesReader' interface.

ronanj commented 8 years ago

Is the chage ok now?

fhs commented 7 years ago

I apologize for the long delay in my response.

It's really hard for me review PR which contains so many unrelated changes. This PR should be split up into few small ones.

The Variable.AddAttr method you added is the same as Variable.Attr followed by Attr.WriteBytes. The other changes (especially bug fixes) should probably get merged.

ronanj commented 3 years ago

Closing as already merged