fhs / pyhdf

Python wrapper around the NCSA HDF version 4 library
https://pypi.org/project/pyhdf/
Other
46 stars 15 forks source link

Add support for MacOS & Windows wheels. #55

Closed sbrodehl closed 2 years ago

sbrodehl commented 2 years ago

Hi there,

following up on #53 this PR adds support to build wheels for MacOS and Windows.

With the update, the following additional packages will be build and published:

sbrodehl commented 2 years ago

When the Windows wheels are build with Github Actions, can the Appveyor pipeline then be deleted?

fhs commented 2 years ago

When the Windows wheels are build with Github Actions, can the Appveyor pipeline then be deleted?

I think so. It's failing right now and we can have another github action for running the tests in windows.

sbrodehl commented 2 years ago

PR #56 already adds tests for Windows :+1:

sbrodehl commented 2 years ago

I went ahead and removed the Travis and Appveyor pipelines and updated the readme. One thing I was wondering: How are the anaconda packages build and deployed?

fhs commented 2 years ago

How are the anaconda packages build and deployed?

https://github.com/conda-forge/pyhdf-feedstock The conda-forge devs maintain it, not me.

sbrodehl commented 2 years ago

Good, so I didn't break anything there. What else is missing in this PR to get this merged?

sbrodehl commented 2 years ago

I bumped the version in the last commit, that's it, I guess?

sbrodehl commented 2 years ago

It looks like the Appveyor build need to be disabled in the settings somewhere. The build is still 'running', but without any project to build, see pyhdf/builds/43476907

fhs commented 2 years ago

@sbrodehl Yep, I've removed Appveyor access to this repo. Hopefully that is enough.