search

fhs / pyhdf

Python wrapper around the NCSA HDF version 4 library
https://pypi.org/project/pyhdf/
Other
46 stars 15 forks source link

hdf4 hdfi.h include goes away in the next release #70

Closed schwehr closed 2 months ago

schwehr commented 6 months ago

The hdfi.h include here https://github.com/fhs/pyhdf/blob/e8f87adb3f308fc6dc6105aa631e2c659da8f4e6/pyhdf/hdfext.i#L206 goes away in hdf4 here: https://github.com/HDFGroup/hdf4/commit/ec211cddbeb8c5bebe7404254a42cc6d686daa6f

For my build, I was able to just remove that line and things built and tested fine.

Note that HDF4 has been undergoing a ton of cleanup recently. It's worth taking a careful look at pyhdf to coordinate with hdf4 before its next release

@derobins

derobins commented 6 months ago

HDF4 has historically had a very poor separation of public vs. private interfaces. In 4.3.0, which will release at the end of February, we've finally stopped deploying internal header files like hdfi.h. For people who are using the public API, as defined in the reference manual, user guide, etc., you should no longer need hdfi.h. FWIW, you didn't need to include that file at any time, since it was pulled in by hdf.h.

Once you've stopped including hdfi.h, ping us over at https://github.com/HDFGroup/hdf4 and we'll create a CI action to make sure pyhdf doesn't break as we change things.

sebastic commented 5 months ago

HDF 4.3.0 has been released, with which pyhdf fails to build as reported in Debian Bug #1068384.