search

fhsav / clock

The clock for Farmington High School.
http://fhsclock.com
Other
12 stars 2 forks source link

Notices do not appear unless URL is /clock #365

Closed gluxon closed 9 years ago

gluxon commented 9 years ago

Notices do not appear unless the current URL is /clock. This means 2 things

  1. Notices only appear when the admin is logged in
  2. Notices do not appear in the theme preview

Duplicates: #295, #364

gluxon commented 9 years ago

Culprit:

/app/views/clock/_main.haml line #6

- unless @n.empty? or request.fullpath != "/clock"
  %footer#notices
    %ul
      - @n.each do |n|
        %li= n.text

@eturk I'm pushing a commit to fix this right now. Can you confirm this wasn't somehow intentional?

ethnt commented 9 years ago

You know, now that I think of it, I think that was for security reasons to prevent people from outside the school seeing notices. Ask Foreman about that.

— Ethan Turkeltaub ethnt.me @ethnt

On Fri, Oct 17, 2014 at 12:35 PM, Brandon Cheng notifications@github.com wrote:

Closed #365 via 3ca8828f086c0e0152fc1f843b4724ad7f638efe.

Reply to this email directly or view it on GitHub: https://github.com/fhsav/clock/issues/365#event-180113937

gluxon commented 9 years ago

@eturk Thanks for the quick response. I mentioned it to Mr. Foreman and he remembered that he did indeed asked you to hide it from public view. (More to prevent confusion than security.) Our solution right now is a hidden get parameter to show notices through. (fhsclock.com/display)

If you have time, can you help me with a small issue that's stumping me at the moment? I added a notice with the message "test" this morning and couldn't get it to view on fhsclock.com. I tested it locally to verify that this issue (#365) was fixed and it worked perfectly. Around 4 PM, my "test" message started displaying (without my action), so I went back in and deleted the notice. However, it's still there in the display. Do you think one of the services being used is caching it?