fhteam / laravel-amqp

AMQP driver for Laravel queue
GNU General Public License v2.0
28 stars 12 forks source link

Bug fix: missing priority/attempts on failed jobs. Feature: message priorities as a standard field #23

Closed foenixteam closed 6 years ago

foenixteam commented 6 years ago

Hi, I have spent the last few days trying to understand what is going on inside Laravel's queue code, and your particular driver. We observed a bug where failing jobs do not preserve the attempt-count and the priority of the job. Both of these have been fixed in this commit, which mainly focuses on how laravel parses the job into JSON, and a message-priority helper. I have tried to take a light-touch approach to modifying code. Anyway, please have a look at the code and message me with any questions you may have. I'm happy to jump on skype too for a chat. All the best, Mils

martianoff commented 6 years ago

at the same time i don't have issues with attempts

FractalizeR commented 6 years ago

@foenixteam Thanks for your contribution. But could you please:

foenixteam commented 6 years ago

Apologies, I didn't even notice the formatting change, our IDE did it automagically. I will re-implement the changes tomorrow with correct formatting / package name, as a separate pull-request. Thanks,

FractalizeR commented 6 years ago

Sure!