fhuhne / CR-Unblocker

This will get a US session id and set the cookie for it on crunchyroll
MIT License
76 stars 15 forks source link

Fails to work with Firefox Nightly 87.0a1 #4

Closed palopezv closed 1 year ago

palopezv commented 3 years ago

I noticed that the region switch stopped working with Firefox Nightly 87.0a1 (2021-02-20) or maybe sometime last week. Firefox 85.0.2 works fine, but this breakage may drip down to release.

Marocco2 commented 3 years ago

Firefox Nightly 87.0a1 (2021-02-22) here. Everything is working as intended. Not sure why do you face this issue

palopezv commented 3 years ago

@Marocco2 Geolocation maybe? I'm in South America while you are in Europe, I posit?

palopezv commented 3 years ago

OK, I think I've got it. The things I'm interested only show up if you force US English as site language but CR detects my location and defaults to latam Spanish. I wonder if the extension could force this along with the US cookie. (I'm null when it comes to javascript).

fhuhne commented 3 years ago

That should be easy to implement, as the language is stored in another cookie. I would make it a toggle though, because not everyone may want this behaviour. I'll take a look into this next weekend and, if there are no further steps involved, implement it right away.

fhuhne commented 1 year ago

As far as I can tell language is now a profile setting and no longer cookie based. I might add a note in the next update about language settings to make it more apparent that this is required.