fi3ework / vite-plugin-checker

πŸ’¬ Vite plugin that provide checks of TypeScript, ESLint, vue-tsc, Stylelint and more.
https://vite-plugin-checker.netlify.app
MIT License
993 stars 86 forks source link

yarn install --frozen-lockfile shows a warning: The engine "vscode" appears to be invalid. #293

Open johnferguson-at-nuix opened 10 months ago

johnferguson-at-nuix commented 10 months ago

Describe the bug

During install of dependencies I get a warning about a transitive dependency being wrong:

yarn install --frozen-lockfile
yarn install v1.22.21
warning ../package.json: No license field
[1/4] πŸ”  Resolving packages...
[2/4] 🚚  Fetching packages...
warning vscode-languageclient@7.0.0: The engine "vscode" appears to be invalid.
[3/4] πŸ”—  Linking dependencies...
[4/4] πŸ”¨  Building fresh packages...
✨  Done in 4.01s.

Upon using the yarn why command this dependency is linked to vite-plugin-checker:

yarn why vscode-languageclient
yarn why v1.22.21
warning ../package.json: No license field
[1/4] πŸ€”  Why do we have the module "vscode-languageclient"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] πŸ”  Finding dependency...
[4/4] 🚑  Calculating file sizes...
=> Found "vscode-languageclient@7.0.0"
info Reasons this module exists
   - "vite-plugin-checker" depends on it
   - Hoisted from "vite-plugin-checker#vscode-languageclient"
info Disk size without dependencies: "944KB"
info Disk size with unique dependencies: "1.43MB"
info Disk size with transitive dependencies: "2.14MB"
info Number of shared dependencies: 5
✨  Done in 0.16s.

Reproduction

Going into my repository I execute:

  1. git clean -dxf
  2. yarn install --frozen-lockfile

Expected behavior

I am expecting to not get a warning about transitive dependencies brought in by vite-plugin-checker

yarn install --frozen-lockfile
yarn install v1.22.21
warning ../package.json: No license field
[1/4] πŸ”  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] πŸ”—  Linking dependencies...
[4/4] πŸ”¨  Building fresh packages...
✨  Done in 4.01s.

System Info

System:
    OS: macOS 12.0.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 73.06 MB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v18.18.2/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 15.1
  npmPackages:
    vite-plugin-checker: ^0.6.2 => 0.6.2

Additional context

This is not a blocker assuming that it doesn't indicate a more serious issue. I noticed this: https://github.com/microsoft/vscode/issues/91009

One poster commented:

In this case it's useless warning and can be ignored. Unfortunately - only way to hide error specifically for vscode - only all errors about engine yarn install --ignore-engines

Perhaps this error can be ignored? If so this issue can be closed.

Validations

StijnMaenhautCZ commented 8 months ago

+1 Experiencing the same issue.