fi3ework / vite-plugin-checker

💬 Vite plugin that provide checks of TypeScript, ESLint, vue-tsc, Stylelint and more.
https://vite-plugin-checker.netlify.app
MIT License
1k stars 87 forks source link

Typescript message shows as red for "0 errors found" in node ^20.15.1 #390

Open gkiely opened 2 months ago

gkiely commented 2 months ago

Describe the bug

image

Reproduction

https://github.com/gkiely/vite-plugin-repro

Expected behavior

Should show as white, so as not to confuse with errors

System Info

System:
    OS: macOS 12.7
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1023.53 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.15.1 - ~/.volta/tools/image/node/20.15.1/bin/node
    Yarn: 1.22.18 - ~/.volta/tools/image/yarn/1.22.18/bin/yarn
    npm: 10.8.0 - ~/.volta/tools/image/npm/10.8.0/bin/npm
    bun: 1.1.25 - ~/.bun/bin/bun
    Watchman: 2024.08.12.00 - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: 114.1.52.129
    Chrome: 127.0.6533.120
    Edge: 127.0.2651.105
    Safari: 17.5
  npmPackages:
    vite-plugin-checker: ^0.7.2 => 0.7.2

Additional context

No response

Validations

hooch commented 2 months ago

Probably this should be a different issue, but perhaps it's in a similar part of the code.

Everything gets underlined in red, regardless of whether it's a warning or an error.

gkiely commented 1 month ago

Fix is to change this line: https://github.com/fi3ework/vite-plugin-checker/pull/393/files#diff-41d1c7c4522702a7fffc786aff11b20c2391952df70678d1ffe12b6f934b9a0dR111 const color = 'white';

image image