Feat/rotary dimmer command class parameters

fiLLLip / namron-homey

Athom Homey app repository to add support for Namron Z-wave devices

GNU General Public License v3.0

8 stars 7 forks source link

Feat/rotary dimmer command class parameters #11

Closed aasmundbo closed 4 years ago

aasmundbo commented 4 years ago

I got around to do this faster than I expected.

Added all the configuration parameters to the rotary dimmer. Default dimming speed and default brightness does not seem to have any effect (or it doesn't match the user manual).

Delay time when turning load off also applies then turning load on.

fiLLLip commented 4 years ago

If you resolve the conflicts we can get this in :+1:

aasmundbo commented 4 years ago

Will resolve once I get time to sit down and do it. This branch is based on master, I’ll base it on the other dimmer branch instead

fiLLLip commented 4 years ago

I think the master was updated since you branched out, so rebase on current master should be fine :)

aasmundbo commented 4 years ago

Branch rebased on top of master. Please review and merge, @fiLLLip.

fiLLLip commented 4 years ago

LGTM!