fiLLLip / namron-homey

Athom Homey app repository to add support for Namron Z-wave devices
GNU General Public License v3.0
8 stars 7 forks source link

Namron Z-wave wallcontroller 8 button (black - flow/scenes) #16

Open ryvaenge opened 4 years ago

ryvaenge commented 4 years ago

Namron`s own products seems to have been shipped at first with manufacturer id ID: 816 (sunricher?) before they got their own manufacturer id: 1080 (namron)

I see you have made 2 different "drivers" for 8 button, one for white (manufacturerid: 816), and one for black (manufacturerid: 1080)

"productTypeId": 768 and "productId": 41733, is the same for both products so it is basicly the same device but different colours.

So wouldnt it be better to put both manufacturer ids into the existing white driver?

The question that I want to ask is, is there anything wrong with the flow/scene coding in your driver for wallcontroller8-black (manufacturerid:1080)?

Because the only triggers that come up is: Battery level changed Battery Alarm activated Battery Alarm deactivated.

Thank you :D

fiLLLip commented 4 years ago

Unfortunately, the data structure in Homey is so that manufacturerId is a string, not an array. Over to the bug, I'm not able to debug this myself, since I don't own a Homey nor a black 8 button Namron panel. If you are able, could you do some zwave debugging to see what zwave commands flows when pushing the buttons? The code should be a complete copy/pasta of the white button.

ryvaenge commented 4 years ago

I am sending this on behalf of others. If you don`t have a Homey I understand it would be hard to debug.

I made him log what the wallcontroller sends. It does send scene number: {"type":"Buffer","data":[1]},"Scene Number":1}

I could not eihter discover any difference between the white and black drivers for 8 button. So then I discovered today why I guess flows/scene is working for me on the white one (816). Even when added via namron app it has used heatit drivers and lies under the heatit app.

So I edited the heatit app with manufacturer id 1080, and made him CLI install that, and that works, so must be something wrong with the scene/flow in namron app.

Need more research.

"Unfortunately, the data structure in Homey is so that manufacturerId is a string, not an array."

Do I understand correct if you mean that you cant have 2 manufacturer ids on one driver? If so, that is done in for example the heatit app. ( "manufacturerId": [411, 816],)

fiLLLip commented 4 years ago

I am sending this on behalf of others. If you don`t have a Homey I understand it would be hard to debug.

I made him log what the wallcontroller sends. It does send scene number: {"type":"Buffer","data":[1]},"Scene Number":1}

I could not eihter discover any difference between the white and black drivers for 8 button. So then I discovered today why I guess flows/scene is working for me on the white one (816). Even when added via namron app it has used heatit drivers and lies under the heatit app.

So I edited the heatit app with manufacturer id 1080, and made him CLI install that, and that works, so must be something wrong with the scene/flow in namron app.

Well, that is really weird, because my sister has this set up in their house, using the button push events for the 8 button panel in flows. I haven't gotten any feedback about it being broken :thinking:

I'll have a look at the Heatit app :+1:

Do I understand correct if you mean that you cant have 2 manufacturer ids on one driver? If so, that is done in for example the heatit app. ( "manufacturerId": [411, 816],)

That is actually great news! Homeys documentation says data is string for this, that is why I thought so... This means I can remove some of the integrations that is duplicate only for this purpose! :smile:

fiLLLip commented 4 years ago

I have updated the code, and pushed to test. https://homey.app/no-no/app/net.filllip-namron/Namron/test/ It is now shared code between white and black button

ryvaenge commented 4 years ago

Tested with manufacturer id: 816, had to deactivate both Heatit and ROBB Smarrt apps to get it added under Namron app. But strangly when added to heatit and robbsmart it did add as secure, both those apps should be unsecure for me, so might still have used namron drivers??

Scene in flows show for me under Namron app.

Will try to find someone with a manufacturer id: 1080 to test.

kristjanhaukur commented 4 years ago

I have the same problem as intitially reported, the only available triggers are battery events. Another thing is that the wallcontroller does not show up as a device in the Namron app. I have tried adding the wallcontroller to the Heatit and Robb smart apps and have the same problems there.

fiLLLip commented 4 years ago

I have the same problem as intitially reported, the only available triggers are battery events. Another thing is that the wallcontroller does not show up as a device in the Namron app. I have tried adding the wallcontroller to the Heatit and Robb smart apps and have the same problems there.

Hi @kristjanhaukur can you check manufacturerId, productTypeId and productId? Could you also check what happens when you press a button inside the zwave section in the homey developer portal?

kristjanhaukur commented 4 years ago

Oops, just returned the product to the store... All I remember is that the manufaturerid was 1080.

fiLLLip commented 4 years ago

Oops, just returned the product to the store... All I remember is that the manufaturerid was 1080.

Its hard to recreate without having the product, and Elektroimportøren doesn't seem so keen on providing products for development either. Someone with development knowledge needs to buy it and help out here if we want to see support for it I guess...