search

fiaas / fiaas-deploy-daemon

fiaas-deploy-daemon is the core component of the FIAAS platform
https://fiaas.github.io/
Apache License 2.0
55 stars 31 forks source link

Support NodeSelectors #139

Open edupedup opened 3 years ago

edupedup commented 3 years ago

We are using fiaas to deploy our API and It does the job, but now we also would like to deploy different types of applications like streaming, ML or batch applications that require pods to be scheduled on specific nodes. Taints are not sufficient as it does not restrics API pods to be scheduled on those nodes. Therefor we would like to be able to add nodeSelectors to our pods.

The idea would be to add to the spec file a field like :

  nodeSelector:
    disktype: ssd

We would really like to have this feature, wdyt ?

gregjones commented 3 years ago

It sounds good to me. Do you think you'll be able to work on this?

xavileon commented 2 years ago

@fiaas/maintainers we may start working on this feature in the close future. It would basically mean adding nodeSelector matching by node label to the FIAAS spec as done in the issue description. The interface seems quite simple and clear for the user.

Is there any concern in adding this feature that we didn't consider?

bjornakr commented 2 years ago

We discussed this in the FIAAS maintainers team, and it looks good to us. Feel free to move forward with this.

portega-adv commented 2 years ago

Thanks @bjornakr, I'll talk with the team to schedule the implementation. We'll keep you updated!