fiaas / mast

Apache License 2.0
2 stars 7 forks source link

Remove deprecated PaasBetaApplication app support #28

Closed xavileon closed 4 years ago

xavileon commented 4 years ago

PaasBetaApplication/Status was the 1st generation FIAAS application. It is no longer supported in FIAAS so let's remove it from MAST as well.

Change-Id: I41526f4b3d744d7180f71ae725a4a21b4ca418ec

Pull Request created with maiao currently in beta stage Please report any bug on slack channel #spt-engprod and feel free to contribute or provide feedback

xavileon commented 4 years ago

@mortenlj I changed the name to check_models for the previous select_models. Any hint on how to proceed with the newly identified code issues in Codacy?

mortenlj commented 4 years ago

I changed the name to check_models for the previous select_models. Any hint on how to proceed with the newly identified code issues in Codacy?

It's one of my least favourite features of Codacy, it sometimes enables a new linter/checker tool, which has stupid rules. Those rules apparently come from PyLint, and apparently PyLint developers have never written tests. I've disabled the PyLint checker, so next time it will ignore these kinds of issues. For now, just ignore the failed check.