codecov[bot]
commented
6 months ago Codecov Report
Attention: Patch coverage is 99.30556% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 98.23%. Comparing base (
c69f8ef) to head (595917d). Report is 7 commits behind head on main.:exclamation: Current head 595917d differs from pull request most recent head e75ca5d. Consider uploading reports for the commit e75ca5d to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ir_api/core/specifications/reduction.py | 96.96% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #277 +/- ## ========================================== + Coverage 97.96% 98.23% +0.26% ========================================== Files 17 21 +4 Lines 491 566 +75 ========================================== + Hits 481 556 +75 Misses 10 10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
keiranjprice101
closes #270 closes #246 closes #252
This PR does 3 things:
The spec and repo, results in a significantly reduced test burden and other benefits discussed. As well as allowing us to more cleanly apply sorting and pagination via simple function and decorator.
For the frontend endpoint changes
It is now possible to filter by run fields that exist on the frontend table from the /instrument/<>/reductions table The count endpoints have been added And the endpoint to see all runs for an instrument
Based on now closed #251