search

fiaisis / FIA-API

ReST API for FIA
GNU General Public License v3.0
0 stars 1 forks source link

Filter script for ghp tokens #331

Closed Pasarus closed 3 months ago

Pasarus commented 3 months ago

Closes #324

Description

I noticed an issue with the scripts being shown to users still containing the ghp token, whilst there are no permissions on the token we use it to increase the download cap for Mantid when downloading Mantid Instrument data inside of containers.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.52%. Comparing base (eb919f6) to head (f896238).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #331 +/- ## ========================================== + Coverage 87.23% 87.52% +0.28% ========================================== Files 18 18 Lines 517 529 +12 ========================================== + Hits 451 463 +12 Misses 66 66 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Pasarus commented 3 months ago

I think all failures in the CI are not caused by this PR @keiranjprice101 do you agree with this evaluation?

keiranjprice101 commented 3 months ago

Yeah they are not. They are caused from the new table and faker as previously discussed