fiaisis / run-detection

The way we detect when our system for reduction should automatically perform a reduction and with what arguments we should do that.
GNU General Public License v3.0
1 stars 1 forks source link

[Run-Detection] Investigate if we can extract the stitch logic into the superclass or common rules module #230

Closed keiranjprice101 closed 8 months ago

keiranjprice101 commented 8 months ago

Description of the issue

The logic will only be parially movable as some elements of stitch rules are instrument specific.

keiranjprice101 commented 8 months ago

While this is possible through a few different methods (composition, strategy pattern, inheritance) There is not one way to do this which doesn't result in overengineered logic that is hard to reason about. This is because there are slight changes between each instruments stitching which means it can't be done in the most simple way