Move from NexusMetadata to DetectedRun this is to make the class more inline with what is in the database schema
Changed the control flow of specification checking to modify a new attribute on DetectedRun, specifically will_reduce This is necessary to allow additions to be added via rules e.g. the additional files. Note that this field is removed when the run is loaded as a json string as it is not necessary downstream.
Created a new rules package. This is to keep the structure more clean in the future as additional rules are added.
Within this new package the existing rules and specification related classes and functions have been moved.
For adequate end to end testing the data within the mantid repo is not sufficient. I am currently in conversation to determine what additional data we can easily get, and a big expansion of e2e testing should then occur. There is an issue open for this.
A few significant changes in this PR:
NexusMetadatatoDetectedRunthis is to make the class more inline with what is in the database schemaDetectedRun, specificallywill_reduceThis is necessary to allow additions to be added via rules e.g. the additional files. Note that this field is removed when the run is loaded as a json string as it is not necessary downstream.rulespackage. This is to keep the structure more clean in the future as additional rules are added.For adequate end to end testing the data within the mantid repo is not sufficient. I am currently in conversation to determine what additional data we can easily get, and a big expansion of e2e testing should then occur. There is an issue open for this.