fiaisis / run-detection

The way we detect when our system for reduction should automatically perform a reduction and with what arguments we should do that.
GNU General Public License v3.0
1 stars 1 forks source link

Implement mari #68

Closed keiranjprice101 closed 1 year ago

keiranjprice101 commented 1 year ago

closes #61

Description

This PR implements the majority of the mari functionality, with one part left untested. The part that is untested will be covered in #71 post meeting with Duc

What is complete and tested in this PR:

As a new issue is opened from this, there is an overall coverage drop of 2%, but this will be remedied post #71

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 88.05% and project coverage change: -2.08 :warning:

Comparison is base (20592b7) 97.06% compared to head (808d619) 94.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #68 +/- ## ========================================== - Coverage 97.06% 94.99% -2.08% ========================================== Files 18 19 +1 Lines 579 719 +140 ========================================== + Hits 562 683 +121 - Misses 17 36 +19 ``` | [Impacted Files](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction) | Coverage Δ | | |---|---|---| | [rundetection/rules/mari\_rules.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-cnVuZGV0ZWN0aW9uL3J1bGVzL21hcmlfcnVsZXMucHk=) | `37.03% <37.03%> (ø)` | | | [rundetection/run\_detection.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-cnVuZGV0ZWN0aW9uL3J1bl9kZXRlY3Rpb24ucHk=) | `94.54% <50.00%> (-1.69%)` | :arrow_down: | | [rundetection/rules/factory.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-cnVuZGV0ZWN0aW9uL3J1bGVzL2ZhY3RvcnkucHk=) | `80.00% <80.00%> (ø)` | | | [rundetection/ingest.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-cnVuZGV0ZWN0aW9uL2luZ2VzdC5weQ==) | `100.00% <100.00%> (ø)` | | | [test/test\_ingest.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-dGVzdC90ZXN0X2luZ2VzdC5weQ==) | `99.05% <100.00%> (+1.32%)` | :arrow_up: | | [test/test\_specifications.py](https://codecov.io/gh/interactivereduction/run-detection/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction#diff-dGVzdC90ZXN0X3NwZWNpZmljYXRpb25zLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=interactivereduction)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.