search

fians / Waves

Click effect inspired by Google's Material Design
http://fians.github.io/Waves/
MIT License
3.48k stars 503 forks source link

Use overlay wrapper for waves and its ripple effect #178

Open fians opened 7 years ago

fians commented 7 years ago

I think it would be good if Waves create an overlay wrapper element inside an actual element and put all the ripple effect child there.

Instead doing this:

<a href="#" class="waves">
  This is button
  <i class="ripple"></i>
  <i class="ripple"></i>
  <i class="ripple"></i>
</a>

Waves should doing like this:

<a href="#" class="waves">
  This is button
  <span class="wrapper">
    <i class="ripple"></i>
    <i class="ripple"></i>
    <i class="ripple"></i>
  </span>
</a>
fians commented 7 years ago

I think this will fix #147, #132 and I hope it also fix bootstrap issue on #144

miguelcobain commented 5 years ago

This would be very helpful.