search

fiatjaf / classless

The same HTML, multiple CSS themes.
https://classless.fiatjaf.com
Other
36 stars 6 forks source link

Suggested format for comment styling #3

Open screenbeard opened 6 years ago

screenbeard commented 6 years ago

I'm interested in writing a theme using classless, but I was hoping to use it with a site I have that already has comments I want to import and keep. I could shoehorn them in, but I'm wondering if there would be a "right" way of laying out comments in the Classless manner. Searching around I can't find a mention of it.

fiatjaf commented 6 years ago

Yes, this is complicated. I tried to come up with a standard for comments, but decided to not do it before discussing it with other people. We could come up with something now. The problem is that none of the themes already support comments, and if we hardcode it and say "we have comments like this" it will become harder for anyone to create themes.

On the other hand, we could make it "optional" or perhaps even an "extension", meaning that we can have themes that support and comments that don't support comments, but this also may increase the mental burden of using the project. Nonetheless, comments are almost essential to blogs everywhere, so I feel we should support this.

What do you think?

fiatjaf commented 6 years ago

In the past I've experimented in my personal website with putting comments on main > article > section ul. A section inside the main article does not make sense for me to anything else besides comments, so I guess that's a good place. Also, by making comments a list of items, someone could expand it later to support nested comments, which makes sense.

fiatjaf commented 6 years ago

Ursprung has adapted the default Classless template and included a direct ol inside the article, but is styling it with specific classes. The comment form there is just a form after the article.

screenbeard commented 6 years ago

I think the idea of an extension would be good. I've had a go at creating a classless theme, and implemented comments in the way you've indicated on your personal website. It works well.

I've got a few more questions about the way you've implemented single pages vs lists of posts. Would that be better in a separate issue, or would you prefer if I emailed you?

fiatjaf commented 6 years ago

A separate issue is probably the best place.