search

fiatjaf / module-linker

browse modules by clicking directly on "import" statements on GitHub
https://module-linker.fiatjaf.com/
MIT License
251 stars 20 forks source link

19-color legend #54

Closed sarehag closed 5 years ago

sarehag commented 5 years ago

A suggestion for color legend in options.html based on discussion in #19 . Verified styling in in chromium and firefox.

fiatjaf commented 5 years ago

This is great, thank you.

But can you import the colors from links.css instead of redefining them at the options file? I believe you can just include links.css and reference the colors with var(--ball-colour-default) and so on.

fiatjaf commented 5 years ago

Is it ready to merge?

sarehag commented 5 years ago

Broke out a root.css to not include unnecessary css in options.html. If you prefer just the first commit, i can revert this refactoring. Tested in chrome and ff. As for whether it is ready for merge, that depends on what requirements for a merge this repo has? I think it should be ok, but would change it if there is anything you would like to have changed.

fiatjaf commented 5 years ago

It's very good.