master missing commits - Githubissues

bndw commented 1 year ago

Still missing a handful of commits that were removed from master a week ago. Here's one example.

What can we do to restore these commits?

And based on seeing https://github.com/fiatjaf/khatru, will relayer be maintained moving forward? It seems like khatru is a hard fork.

fiatjaf commented 1 year ago

I've included that one now.

fiatjaf commented 1 year ago

What do you think of khatru? Do you think it is better than relayer? I made because I couldn't bring myself to use relayer, it had too many flaws. If khatru is strictly superior then I don't see why we would want to keep messing with relayer.

bndw commented 1 year ago

I see you implemented LMDB which is something I am interested in. I will give it a deeper look.

Alternatively, you could just make the khatru breaking change as a PR to this repo, merge it, and tag a v3. The benefit I see to that approach is it

maintains the "relayer" name, it's pretty good and intuitive
does not split the community. there are users/builders on relayer

But ultimately it's your call. I will check out the new repo either way. As someone relying on relayer today, I'm just hoping for a relatively stable framework in Go for building my relay; one that has some community behind it so I hopefully get free bug fixes 😄

fiatjaf commented 1 year ago

But then people will update to the v3 and everything will break for them and they will be mad.

fiatjaf / relayer

master missing commits #87