fiatjaf / window.nostr.js

drop-in <script> that adds seamless NIP-46 support to apps that rely on window.nostr
https://git.njump.me/wnj
23 stars 2 forks source link

Auth_url isn't shown/explained properly for signEvent and other methods #3

Closed nostrband closed 5 months ago

nostrband commented 5 months ago

Right now, onauth callback only knows two states - 'creating' (signup) or login. But there is a third state where auth_url is sent in response to other method calls. Right now those are treated as login and I see a "Login now" button in window.nostr.js, instead of a "Confirm action" button. That's probably confusing for users.

dtonon commented 5 months ago

Fixed in fbdb62a6

https://github.com/fiatjaf/window.nostr.js/assets/89577423/0379687c-2db9-4988-b4b5-aafbfda32658