search

fibasile / nueval-project

Project Management and Docs for nueval
0 stars 0 forks source link

complete mark irreversible #14

Closed emmapa closed 7 years ago

emmapa commented 7 years ago

Something strange happened.

In both local and global evaluation app, these are the steps I followed: 1- I marked complete the single week and if it the week is marked complete I can still change the feedback. see image 1, it refers to the global eval. image_1

1- I marked all the units as complete and the option to change the feedback of the single week disappeared. see image_2, it refers to the global eval. Even if I change the outcomes status bar, the week remains complete. image_2 It looks like if you mark all the weeks as complete, you can't change your feedback anymore.

Is it ok like that?

fibasile commented 7 years ago

This is totally a bug. When the unit is complete, no edits must be allowed to the sliders.

Only Leave feedback should work to leave comments

fibasile commented 7 years ago

This should be fixed now!

emmapa commented 7 years ago

I tried with a new student and global evaluation, and the bug is still there. Once all the units are marked complete, the "not complete" option disappeared.

fibasile commented 7 years ago

This "Marked complete" disappearing is correct in my opinion, once you marked all the unit complete in my model, you can move to two states 1) graduated or 2) next cycle

On the other bug, you can't save anymore when is complete, and you shouldn't be able to change the outcomes, right?

2017-06-26 8:42 GMT+02:00 Emma notifications@github.com:

I tried with a new student and global evaluation, and the bug is still there. Once all the units are marked complete, the "not complete" option disappeared.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fibasile/nueval-project/issues/14#issuecomment-310976103, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAszJMSji2legFuorDQWD3ez4IPf6Zks5sH1LZgaJpZM4OEkCO .

--

Fiore Basile Mobile. +39 3284576081 Email. fiore.basile@gmail.com Twitter. @fibasile http://fablabtoscana.it http://fablabcascina.org http://fabconnections.org http://fabacademy.org http://fabeconomy.com http://fibasile.github.io http://artigianatodigitale.com

fibasile commented 7 years ago

closing now